created the amixer sget command parser - READY FOR REVIEW #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created the initial skeleton to ensure I understood how to properly create and place a pull request in the correct repository and branch. |
AvocadoStyle
changed the title
AvocadoStyle
force-pushed
the
feature/amixer-new-parser
branch
from
9642d82 to
6a02b3d
Compare
|
Now I've set this branch to track the dev branch, and its upstream is now based on dev. |
…rious of strings.
…he amixer tool output and algorithm of the input parsing and input examples.
AvocadoStyle
commented
Nov 27, 2024
AvocadoStyle
commented
Nov 27, 2024
AvocadoStyle
commented
Nov 27, 2024
AvocadoStyle
commented
Nov 27, 2024
|
@kellyjonbrazil The pull request has been finalized and is now ready for your review. Please take a look and let me know if you have any feedback or suggestions for improvement. |
AvocadoStyle
changed the title
kellyjonbrazil
requested changes
Nov 29, 2024
|
@kellyjonbrazil It's your turn, And thanks for the feedback. |
…c into feature/amixer-new-parser
kellyjonbrazil
requested changes
Dec 1, 2024
… parser for raw=False.
This reverts commit 241d1a1.
AvocadoStyle
commented
Dec 4, 2024
|
@kellyjonbrazil Ready for review again, Finished with the:
I have a request
Thanks! |
|
Looks great - just a couple more things and should be ready to merge! |
|
@kellyjonbrazil Thanks, Your turn. |
|
Thank you for the parser contribution! Nice work - I'll merge this in and it will make it into the next release. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as part of the following github issue: #591 (comment)
Which is #591
Created this amixer PR.